Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast review fixes #103

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Cast review fixes #103

merged 4 commits into from
Oct 13, 2020

Conversation

deepFlaw
Copy link
Contributor

I found a couple issues when playing through the All-Cast Review Session today:

  1. A single line acts like the player has read Taraimawashi, which is very unlikely to be true unless they are actually playing on a console. This is also inconsistent with other lines that talk about Onikakushi as "the previous scenario". To counter this I've readded the original PC line on the default voice matching level and below. (I opened issue All-Cast Review suddenly mentions console arc #102 for this, but found it was easier to implement myself than expected so I've gone ahead with that here.)
  2. Currently there's a line referring to a "manager" character from Onikakushi. This was eventually changed to "director", so I've now made the same change to be consistent here. (Though I've not played further than this yet - I guess I may be risking inconsistency with the later games.)

deepFlaw added 4 commits July 25, 2020 14:37
Onikakushi now uses "director" instead of "manager", from a year-old change (commit 270946caf41bd5ef8143bf690ee9b103300e9e18).
Console line assumes players have also read Taraimawashi and so should not be default, especially when other lines refer to a singular previous scenario
@ItaloKnox ItaloKnox merged commit 7adc252 into 07th-mod:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants